Re: [PATCH v12 11/12] iommu/arm-smmu-v3: Skip RMR bypass for kdump adoption

From: John Garry

Date: Tue Nov 17 2026 - 09:39:54 EST


On 11/16/26 19:24, Nicolin Chen wrote:
adoption keeps the crashed kernel's table live. Rewriting the
+ * adopted STE here could expose an in-flight fetch to a transient V=0
+ * entry, or change Cfg=translate to Cfg=bypass. Must skip here.
+ */
+ if (smmu->options & ARM_SMMU_OPT_KDUMP_ADOPT)
+ return;
+
INIT_LIST_HEAD(&rmr_list);
iort_get_rmr_sids(dev_fwnode(smmu->dev), &rmr_list);
Did you consider if we should sanitise the adopted ste against what
iort_get_rmr_sids() returns? I suppose that would add even more complexity.
It's not necessary: both crashed and kdump kernels installed them
from the same IORT. If STE is translated, they are mapped as 1:1.
It's certainly not worth the complexity.

BTW, are those regions described in a file(s) in sysfs? I thought that they were, but I can't find it, so I guess that they don't (exist).

Thanks,
John