[PATCH] media: dm1105: Fix potential frontend leak on probe failure
From: Guangshuo Li
Date: Tue Nov 17 2026 - 09:50:32 EST
The frontend is registered before workqueue creation and the IRQ
request. Failures at either stage skip frontend teardown before
releasing the adapter and driver state.
Unregister and detach the frontend on these later probe failures.
This issue was found by our static analysis tool under development.
Fixes: d1498ffc474b ("V4L/DVB (10743): dm1105: not demuxing from interrupt context.")
Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
---
drivers/media/pci/dm1105/dm1105.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c
index ae4544042a74..45f3db06b7b9 100644
--- a/drivers/media/pci/dm1105/dm1105.c
+++ b/drivers/media/pci/dm1105/dm1105.c
@@ -1132,7 +1132,7 @@ static int dm1105_probe(struct pci_dev *pdev,
dev->wq = create_singlethread_workqueue(dev->wqn);
if (!dev->wq) {
ret = -ENOMEM;
- goto err_dvb_net;
+ goto err_frontend;
}
ret = request_irq(pdev->irq, dm1105_irq, IRQF_SHARED,
@@ -1144,6 +1144,9 @@ static int dm1105_probe(struct pci_dev *pdev,
err_workqueue:
destroy_workqueue(dev->wq);
+err_frontend:
+ dvb_unregister_frontend(dev->fe);
+ dvb_frontend_detach(dev->fe);
err_dvb_net:
dvb_net_release(&dev->dvbnet);
err_disconnect_frontend:
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4