Re: [PATCH] dma-buf/dma-fence: Prevent misordering for error checks
From: Christian König
Date: Tue Nov 17 2026 - 09:55:39 EST
On 11/17/26 10:01, Philipp Stanner wrote:
> Many users of dma_fence do things like:
>
> // Thread A
> dma_fence_set_error(f, -EINVAL);
> dma_fence_signal(f); // <- Takes lock, which orders against the above.
>
> // Thread B
> if (dma_fence_is_signaled(f)) // <- Does test_bit(), no ordering.
> pr_info("err: %i\n", f->error); // <- Can be loaded first.
>
> There is no memory ordering between reading of the signaled-bit and
> reading of the error code. This can result in outdated, wrong error
> codes being evaluated by the user.
>
> Though dma_fence_get_status() does take the fence lock, it is equally
> broken because the misordering can simply happen within the critical
> section.
>
> It's not entirely clear since when this bug exists, but at least since
> dma_fence_get_status() was added, which is why its birth commit is
> marked as the Fixes commit here.
>
> Ensure ordering for everyone evaluating the error code centrally by
> using test_bit_acquire() in dma_fence_test_signaled_flag().
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: d6c99f4bf093 ("dma-fence: Wrap querying the fence->status")
> Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>
> ---
> Changes since the RFC:
> - Order with test_bit_acquire(). (Gary)
> - ^ also makes it easy to backport this for now.
> - Try to document roughly what is even going on.
> ---
> include/linux/dma-fence.h | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index dd07d128adc3..a8d23fed70b9 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -496,7 +496,16 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
> static inline bool
> dma_fence_test_signaled_flag(struct dma_fence *fence)
> {
> - return test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
> + // Best-effort ordering of the locklessly evaluated signaled-bit,
> + // especially so that reads of fence->error are not misordered.
> + //
> + // The release counterpart is typically ensured like this:
> + // a) Error codes must only be set before a fence signals and
> + // b) The fence's spinlock's barriers effective in dma_fence_signal()
> + // ensure ordering.
> + // c) For users of dma_fence_signal_locked(), the barrier implied in
> + // test_and_set_bit() should do the trick.
That should probably be a C comment, e.g. /* ... */.
Apart from that really good catch.
Regards,
Christian.
> + return test_bit_acquire(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
> }
>
> /**