Re: [PATCH] drm: renesas: rz-du: Add suspend/resume support

From: Geert Uytterhoeven

Date: Tue Nov 17 2026 - 10:13:00 EST


Hi Tommaso,

On Thu, 12 Nov 2026 at 09:31, Tommaso Merciai
<tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
> Add suspend/resume support to the RZ/G2L DU driver.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> @@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
> .minor = 0,
> };
>
> +/* -----------------------------------------------------------------------------
> + * Power management
> + */
> +
> +static int rzg2l_du_pm_suspend(struct device *dev)
> +{
> + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> +
> + return drm_mode_config_helper_suspend(&rcdu->ddev);

error: passing argument 1 of ‘drm_mode_config_helper_suspend’ from
incompatible pointer type [-Werror=incompatible-pointer-types]

The "&" should be dropped...

> +}
> +
> +static int rzg2l_du_pm_resume(struct device *dev)
> +{
> + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> +
> + return drm_mode_config_helper_resume(&rcdu->ddev);

... likewise.

> +}
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(rzg2l_du_pm_ops,
> + rzg2l_du_pm_suspend, rzg2l_du_pm_resume);
> +
> /* -----------------------------------------------------------------------------
> * Platform driver
> */

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds