Re: [PATCH] mm/mempolicy: fix copy_nodes_to_user() for odd inputs

From: Lorenzo Stoakes (ARM)

Date: Tue Nov 17 2026 - 10:37:12 EST


On Tue, Nov 17, 2026 at 04:26:48PM +0100, Arnd Bergmann wrote:
> On Tue, Nov 17, 2026, at 15:59, Lorenzo Stoakes (ARM) wrote:
> > On Tue, Nov 17, 2026 at 03:25:53PM +0100, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@xxxxxxxx>
> >> For compat syscalls, the effect is worse, as the actual calculation for
> >> the size does include the extra word, but the check for the input size
> >> does not take it into account and can leak a word of stack data.
> >>
> >> In addition, the size calculation rounds up to multiples of 64 bits
> >> instead of multiples of word size as documented in the man page and
> >> expected by numactl.
> >>
> >> Fortunately numactl always passes multiples of 64 here, so none of
> >
> > (Claude) went looking at numactl source (e.g. via libnuma) and it seems it
> > passes size + 1 matching the convention?
>
> Ok, I see it now as well. The man page again says "maxnode specifies
> the number of node IDs that can be stored into nodemask——that is,
> the maximum node ID plus one.", which I'd naïvely interpret as meaning
> that a system with 64 nodes would have a "maximum node ID" of 63 and
> require passing one more (64), but clearly the implementation on
> both sides expects a 65 here.

Yeah which is... special isn't it? :))

>
> >> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> >> index 6d662a9a8c74..f318e1155770 100644
> >> --- a/mm/mempolicy.c
> >> +++ b/mm/mempolicy.c
> >> @@ -1749,12 +1749,12 @@ static int get_nodes(nodemask_t *nodes, const unsigned long __user *nmask,
> >> static int copy_nodes_to_user(unsigned long __user *mask, unsigned long maxnode,
> >> nodemask_t *nodes)
> >> {
> >> - unsigned long copy = ALIGN(maxnode-1, 64) / 8;
> >> + unsigned long copy = ALIGN(maxnode, BITS_PER_LONG) / 8;
> >
> > This looks like it'll be broken given the convention of passing bits + 1,
> > e.g. ALIGN(1025, 64) / 8 != ALIGN(1024, 64) / 8.
> >
> > Then later that could case a buffer overflow potentially?
>
> Right, this would then overflow the user buffer.
>
> > Overall it seems the issue is that e130242dc351 (understandably!) passes maxnode
> > rather than maxnode-1.
> >
> > So a really small fixup would be something like:
> >
> > diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> > index fb627b37afcb..051d411c04ee 100644
> > --- a/mm/mempolicy.c
> > +++ b/mm/mempolicy.c
> > @@ -1733,12 +1733,12 @@ static int copy_nodes_to_user(unsigned long
> > __user *mask, unsigned long maxnode,
> > if (clear_user((char __user *)mask + nbytes, copy - nbytes))
> > return -EFAULT;
> > copy = nbytes;
> > - maxnode = nr_node_ids;
> > + maxnode = nr_node_ids + 1;
> > }
> >
> > if (compat)
> > return compat_put_bitmap((compat_ulong_t __user *)mask,
> > - nodes_addr(*nodes), maxnode);
> > + nodes_addr(*nodes), maxnode - 1);
> >
> > return copy_to_user(mask, nodes_addr(*nodes), copy) ? -EFAULT : 0;
> > }
> >
> > Maybe doing that's the easiest route for this?
>
> I would still try to fix the other mistakes (aligning to 64 instead
> of BITS_PER_LONG/BITS_PER_COMPAT_LONG and the incorrect nbytes).
> Maybe it's clearer to just pass the adjusted maxnode into the
> function directly and keep that extra '-1' in one place?

Yeah it'd be nice to get away from that convention which is... very
confusing :) Especially as 'max' implies to me an inclusive bound.

You could have a wrapper get_nodes() that calls __get_nodes() that has a
'lastnode' parameter for instance?

--
Cheers, Lorenzo