Re: [PATCH] drm: renesas: rz-du: Add suspend/resume support
From: Tommaso Merciai
Date: Tue Nov 17 2026 - 10:44:11 EST
Hi Geert,
On Tue, Nov 17, 2026 at 04:37:34PM +0100, Geert Uytterhoeven wrote:
> Hi Tommaso,
>
> On Tue, 17 Nov 2026 at 16:30, Tommaso Merciai
> <tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
> > On Tue, Nov 17, 2026 at 04:12:43PM +0100, Geert Uytterhoeven wrote:
> > > On Thu, 12 Nov 2026 at 09:31, Tommaso Merciai
> > > <tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
> > > > Add suspend/resume support to the RZ/G2L DU driver.
> > > >
> > > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>
> > >
> > > Thanks for your patch!
> > >
> > > > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > > > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > > > @@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
> > > > .minor = 0,
> > > > };
> > > >
> > > > +/* -----------------------------------------------------------------------------
> > > > + * Power management
> > > > + */
> > > > +
> > > > +static int rzg2l_du_pm_suspend(struct device *dev)
> > > > +{
> > > > + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> > > > +
> > > > + return drm_mode_config_helper_suspend(&rcdu->ddev);
> > >
> > > error: passing argument 1 of ‘drm_mode_config_helper_suspend’ from
> > > incompatible pointer type [-Werror=incompatible-pointer-types]
> > >
> > > The "&" should be dropped...
> >
> > Sorry are you apply this patch on top of some other series?
> > On top of next-20261116 I'm not seeing this issue.
> >
> > Maybe I'm missing somenthing?
>
> Ah, I have your "[PATCH v9 04/10] drm: renesas: rz-du: Reference the
> DRM device by pointer" applied, too...
> https://patch.msgid.link/d5a97ddb346c5cb959b39fda45277afb1fa2ae16.1792770965.git.tommaso.merciai.xr@xxxxxxxxxxxxxx
Ah, thanks for sharing.
Just FYI I posted v10 [1] this apply on top of this patch.
[1] https://lore.kernel.org/all/cover.1794502191.git.tommaso.merciai.xr@xxxxxxxxxxxxxx/
Kind regards,
Tommaso
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds