Re: [PATCH net] net: stmmac: preserve RX checksum capability when offload is disabled

From: Maxime Chevallier

Date: Tue Nov 17 2026 - 10:50:55 EST


Hi James,

On 11/16/26 01:49, James Hilliard wrote:
> The GMAC, GMAC4 and XGMAC rx_ipc callbacks return whether checksum offload
> is enabled after programming the requested state. A zero return is
> therefore expected when hw->rx_csum is zero.
>
> stmmac_hw_setup() treats every zero return as a lack of hardware support
> and clears plat->rx_coe. Disabling RX checksum offload with ethtool and
> then reopening the interface loses the saved capability. Subsequent
> attempts to enable offload are rejected by stmmac_fix_features(), which
> uses plat->rx_coe to filter NETIF_F_RXCSUM.
>
> Only clear the capability if offload was requested but could not be
> enabled. Keep calling rx_ipc when offload is disabled so that the hardware
> is still programmed with the requested state.
>
> Fixes: 0f280e4d23c2 ("stmmac: fix the rx csum feature")

This tag doesn't exist :

https://netdev-ctrl.bots.linux.dev/logview.html?f=/logs/build/1212156/14986330/verify_fixes/stdout

Besides that, this is legit. Tested on AgileX5, CycloneV and stm32mp1:

ip l s eth0 up
ethtool -K eth0 rx off
ip l s eth0 down;
ip l s eth0 up
ethtool -K eth0 rx on

Without patch:
ethtool -k eth0 => rx-checksumming off

With:
ethtool -k eth0 => rx-checksumming on

Please respin with a correct Fixes, feel free to add :

Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
Tested-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Maxime

pw-bot: cr