[PATCH net-next v2 0/5] net/mlx4: TX helpers and deferred doorbell fix

From: Joe Damato

Date: Tue Nov 17 2026 - 10:54:04 EST


Greetings:

I am working on adding support for SW USO to mlx4 and the branch I have with
those changes locally is becoming a bit long, so I thought I'd try to break it
up to make it easier to review and merge by first sending this prep series.

FWIW: I plan to include more detailed data in my SW USO series, but I'm
working on SW USO because it significantly improves performance on hosts with
an IOMMU and an mlx4 NIC. I have a lot of hosts like that in production that
would benefit.

Anyway, back to this series.

Patches 1-3 factor common code out into helpers which currently have only 1
call site each, but I will be calling these helpers in the SW USO code I plan
to submit next.

Patch 4 and 5 add code to track when a doorbell is deferred so that it can
be written in the drop path. This is technically a bug fix (and I need this
to avoid the same type of bug in SW USO), but since I have never seen this bug
occur in reality I am sending to net-next.

Thanks,
Joe

v2:
- Better cover letter subject line :)
- Added Daniel's Reviewed-by to all patches, including patch 4 which has a
minor change (hope that is OK, Daniel).
- Patch 4:
- Change the struct placement to address Sashiko's review. The new flag
is moved to the area of the struct marked as "cache line used and
dirtied in mlx4_en_xmit" and tx_dropped is moved down with the fields
not used in the fast path since it is only written on drop and read
for stats.
- Update the commit message to explain this.

v1: https://lore.kernel.org/netdev/20261110231304.1859217-1-joe@xxxxxxx/

Joe Damato (5):
net/mlx4: factor VLAN parsing into mlx4_en_prep_vlan()
net/mlx4: factor csum flags into mlx4_en_csum_flags()
net/mlx4: factor HW loopback DMAC into mlx4_en_set_loopback_dmac()
net/mlx4: track whether a TX doorbell is pending
net/mlx4: flush pending doorbell when dropping a TX skb

drivers/net/ethernet/mellanox/mlx4/en_tx.c | 95 +++++++++++++-------
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +-
2 files changed, 66 insertions(+), 32 deletions(-)


base-commit: 6bc9aed3994cb04708fef02dd6d2f1cc5c5e8229
--
2.53.1-Meta