Re: [PATCH v5] sched/eevdf: Fix vprot across reweighting

From: Kayra Cizmeci

Date: Tue Nov 17 2026 - 11:15:20 EST


On Fri, Oct 16, 2026 at 06:37:20PM +0300, Kayra Cizmeci wrote:
> Currently in reweighting, while a tasks vruntime changes dead protection
> could go alive, or alive protection could decrease, increase and go dead.
> Fix it in reweight_eevdf(), and just cancel it in the sched_change_end()
> path.
>
> Fixes: 80390ead2080 ("sched/fair: Separate se->vlag from se->vprot")
> Fixes: bcd74b2ffdd0 ("sched/fair: Only set slice protection at pick time")
> Suggested-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Signed-off-by: Kayra Cizmeci <kayracizmeci@xxxxxxxxx>
> ---
> Changes v4->v5:
> * Use Vincent's comment
> * Grab Tags
>
> v4: https://lore.kernel.org/lkml/20261016150402.6952-1-kayracizmeci@xxxxxxxxx/
>
> Not tested.

Well I got bored, so I tested this. I don't know what more to do on this
patch. I already pinged. So the only thing left was testing, I guess.

The results were good. I tried to verify 2 things:

* Only sched change thingies enter the newly added path in enqueue_task_fair()

* All tasks protection gets handled correctly

There were ~318000 reweights of curr, ~48000 of them were alive.
No exceptions :-). Or :-( since if there was an exception atleast it
would be fun to check it out.


Cheers,

Kayra