Re: [PATCH] fork: mark memcpy() in dup_mm() with data_race()

From: Bradley Morgan

Date: Tue Nov 17 2026 - 11:23:36 EST


On 17 November 2026 05:59:56 GMT, Muhammad Haris Awan
<m.harisawan@xxxxxxxxxx> wrote:
>KCSAN reported a data race between dup_mm() copying oldmm via
>memcpy(mm, oldmm, sizeof(*mm)) and lru_gen_del_mm() modifying
>oldmm->lru_gen.list when an adjacent mm_struct on the shared
>mm_list->fifo is removed under mm_list->lock.
>
>oldmm->lru_gen and oldmm->mmlist are protected by mm_list->lock /
>mmlist_lock (or updated locklessly via lru_gen_use_mm()), not
>oldmm->mmap_lock. Because struct mm_struct uses __randomize_layout and
>mm_init() immediately reinitializes these fields on the new mm, wrap
>the memcpy() in data_race(), matching dup_vma() in mm/vma_init.c.
>
>Fixes: bd74fdaea146 ("mm: multi-gen LRU: support page table walks")
>Reported-by: syzbot+c6e1b1b32ff2fc3b7d60@xxxxxxxxxxxxxxxxxxxxxxxxx
>Closes: https://syzkaller.appspot.com/bug?extid=c6e1b1b32ff2fc3b7d60
>Signed-off-by: Muhammad Haris Awan <m.harisawan@xxxxxxxxxx>
>---
> kernel/fork.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/kernel/fork.c b/kernel/fork.c
>index 5efceb8d5..14ac9a070 100644
>--- a/kernel/fork.c
>+++ b/kernel/fork.c
>@@ -1539,7 +1539,12 @@ static struct mm_struct *dup_mm(struct task_struct *tsk,
> goto fail_uprobe;
> }
>
>- memcpy(mm, oldmm, sizeof(*mm));
>+ /*
>+ * oldmm->lru_gen and oldmm->mmlist may be modified concurrently under
>+ * mm_list->lock / mmlist_lock or locklessly via lru_gen_use_mm(),
>+ * and mm_init() will immediately reinitialize them.
>+ */
>+ data_race(memcpy(mm, oldmm, sizeof(*mm)));

NAK. Your basically just ignoring the race, in fork, like Lorenzo said.

Let's fix this somewhere else?

>
> if (!mm_init(mm, tsk)) {
> mmap_write_unlock(oldmm);
>

--- Thanks!