Re: [PATCH] mips: cavium-octeon: fix missing prototypes

From: Thomas Bogendoerfer

Date: Tue Nov 17 2026 - 11:28:11 EST


On Sun, Nov 08, 2026 at 03:31:40PM +0100, Timo Joannin wrote:
> The compiler throws -Wmissing-prototypes warnings for
> several functions in the cavium octeon architecture code.
>
> It occurs due to a mix of hardcoded prototypes scattered
> across C files, a block-scoped extern declaration,
> and missing header files.
>
> Fix the warnings by:
> - Moving the prototype for octeon_fill_mac_addresses() from
> setup.c to <asm/octeon/octeon.h>
> - Removing the block-scoped extern declaration for
> octeon_send_ipi_single() in mm/c-octeon.c and exposing via
> <asm/octeon/octeon.h>
> - Moving the prototype __cvmx_interrupt_gmxx_rxx_int_en_enable()
> from cvmx-interrupt-rsl.c to the cvmx-gmxx-defs shared header.
> - Adding the missing #include <asm/octeon/cvmx-helper-errata.h> to
> cvmx-helper-errata.c.
>
> These changes pass the compiler's -Wmissing-prototypes safety
> checks without changing any runtime logic.
>
> Signed-off-by: Timo Joannin <timo.joannin@xxxxxxxxx>
> ---
> arch/mips/cavium-octeon/executive/cvmx-helper-errata.c | 1 +
> arch/mips/cavium-octeon/executive/cvmx-interrupt-rsl.c | 2 --
> arch/mips/cavium-octeon/setup.c | 2 --
> arch/mips/include/asm/octeon/cvmx-gmxx-defs.h | 2 ++
> arch/mips/include/asm/octeon/octeon.h | 2 ++
> arch/mips/mm/c-octeon.c | 1 -
> 6 files changed, 5 insertions(+), 5 deletions(-)

I've applied https://lore.kernel.org/all/20261101234657.1820661-1-rdunlap@xxxxxxxxxxxxx,
which also cleans up cavium octeon code. So your patch doesn't apply any
longer. Can you check, if all your warning fixes are applied, and if not
send an updates patch ?

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]