Re: [PATCH 0/2] accel/rocket: Fix NULL deref and double-free in job submit error path

From: Daniel Drake

Date: Tue Nov 17 2026 - 11:35:20 EST


Hi,

On 27/05/2026 15:33, D D wrote:
Hi Tomeu,

Two bugs in the job submission error path in rocket_job.c:

1) rocket_job_cleanup() unconditionally calls
rocket_iommu_domain_put(job->domain), but job->domain is only
assigned after all fallible operations in
rocket_ioctl_submit_job(). On early failure, job->domain is NULL,
causing a NULL pointer dereference.

2) rocket_copy_tasks() frees rjob->tasks on its error path but does
not NULL the pointer. rocket_job_cleanup() frees it again,
resulting in a double-free.
Please read the kernel docs on submitting patches, you cannot submit them as attachments.

You also need to rewrite the commit messages to be easily readable by overloaded kernel maintainers. If you are including 10+ function/variable names in a single paragraph, or translating C code into English, it is a sign the commit message is not useful.

Thanks
Daniel