Re: [PATCH] scsi: pm8001: Offset hardware queue index for MSI-X pre-vector

From: TJ Adams

Date: Tue Nov 17 2026 - 12:48:56 EST


On Mon, Nov 16, 2026 at 3:04 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> On 11/16/26 2:48 PM, TJ Adams wrote:
> > - return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(rq));
> > + if (pm8001_ha->number_of_intr > 1)
> > + return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(rq)) + 1;
>
> If "1" in the above statement is not changed into a symbolic constant,
> it will be very hard for anyone who reads the code of this driver to
> determine where that constant comes from.

Good point, and thanks for the feedback. I'll send an updated v2 patch.

Thanks,
TJ