Re: [PATCH v2] ACPI: pfr_telemetry: keep the state until the last file is closed

From: Rafael J. Wysocki (Intel)

Date: Tue Nov 17 2026 - 15:09:34 EST


On Mon, Nov 16, 2026 at 9:09 PM Chad Aldreda <ca@xxxxxxxxxxxxxx> wrote:
>
> On Fri, 13 Nov 2026, Rafael J. Wysocki wrote:
> > Applied as 7.5 material, thanks!
>
> Thanks. Two small things in the applied commits, in case they are
> still easy to change:
>
> 1. Shuangpeng Bai reported the pfr_telemetry use-after-free in June. I
> posted the tags on v1, but v2 did not carry them, so e788ea48810f
> has none:
>
> Reported-by: Shuangpeng Bai <shuangpeng.kernel@xxxxxxxxx>
> Closes: https://lore.kernel.org/all/178144969601.60470.3508974301899957212@xxxxxxxxx/
>
> 2. The message of dacb7cef6f32 ("ACPI: pfr_update: keep the state until
> the last file is closed") also contains my notes from below the ---
> line and the diffstat. Two sentences there no longer match the
> commit: "kzalloc() rather than kzalloc_obj() ... for the stable
> trees" (the code uses kzalloc_obj()), and "No lock is added. A call
> that passed the removed check can run during the unbind ..." (fixed
> by c0ab3714e87a). Deleting everything after your second [ rjw: ]
> line up to the patch.msgid.link Link: tag would drop them.

I'm not really sure what happened here.

> If neither is worth a rebase, no problem.

I've fixed up the above, thanks for the notice!