Re: [PATCH 2/4] accel/rocket: Fix the panic in rocket_iommu_domain_put when the domain is NULL
From: Daniel Drake
Date: Tue Nov 17 2026 - 16:47:27 EST
On 14/08/2026 03:24, Chaoyi Chen wrote:
From: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>This issue was already fixed in commit 70e6a33d68a9b03335c5426332666e52d07f45d6.
In rocket_ioctl_submit_job(), since the domain is assigned last, an
error before that triggers rocket_job_put() -> rocket_job_cleanup()
-> rocket_iommu_domain_put() with the domain still NULL,
causing a panic in that function.
Therefore, the input parameters should be validated.
Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation")
Signed-off-by: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>
This patch is not needed.