Re: [PATCH v2 07/17] drm/spacemit: add Saturn DPU register model
From: Guodong Xu
Date: Tue Nov 17 2026 - 16:48:12 EST
Hi Icenowy,
On Thu, 03 Sep 2026 20:08:10 +0800, Icenowy Zheng wrote:
> 在 2026-08-09日的 21:14 +0800,Cody Kang via B4 Relay写道:
> > drivers/gpu/drm/spacemit/dpu/saturn_regs/dpu_int.h | 25 ++
>
> Is the slightly different K1 Saturn DPU registers considered?
I compared them with the K1 BSP you mentioned offline [1]. Judging by
the block, field and interrupt macro names, I agree with you that the
K1 and the K3 use similar IP. But there are also important
differences between the K1 and K3 registers, which is why I would not
propose reusing these tables.
For example, the blocks sit at different addresses, and most fields
are at a different word or bit. In dpu_int.h, CFG_RDY_CLR is bit 4 on
the K1 and bit 5 on the K3, and the underrun bit is 9 and 8.
IMHO a K1 port should add its own compatible, its own field header
and its own backend file next to the K3 ones. What do you think?
Hopefully you agree with me.
[1] https://github.com/spacemit-com/linux-6.6/tree/k1-bl-v2.2.y/drivers/gpu/drm/spacemit/dpu/saturn_regs
Guodong