Re: [PATCH v4 09/25] dmaengine: sdxi: Allocate administrative context
From: Lynch, Nathan
Date: Tue Nov 17 2026 - 17:08:58 EST
On 11/12/2026 4:10 PM, Frank Li wrote:
> On Tue, Nov 03, 2026 at 08:49:50PM -0600, Nathan Lynch via B4 Relay wrote:
>> +int sdxi_admin_cxt_init(struct sdxi_dev *sdxi)
>> +{
>> + struct sdxi_cxt *cxt __free(sdxi_cxt) = sdxi_alloc_cxt(sdxi);
>> + if (!cxt)
>> + return -ENOMEM;
>> +
>> + cxt->id = SDXI_ADMIN_CXT_ID;
>> + cxt->sq->doorbell = sdxi->dbs + cxt->id * sdxi->db_stride;
>> +
>> + sdxi->admin_cxt = no_free_ptr(cxt);
>> +
>> + return devm_add_action_or_reset(sdxi->dev, free_admin_cxt, sdxi);
>
> If sdxi_alloc_cxt() only called by probe, needn't mix cleanup and devm
> function
True, will fix.