Re: [PATCH] hwmon: (ads7871) Add error handle from spi_setup()

From: Guenter Roeck

Date: Tue Nov 17 2026 - 18:16:00 EST


On 11/17/26 12:51, Vítor Hugo Silva wrote:
The ads7871 probe() ignores the spi_setup() error return value
and it attempts to write on registers even if spi_setup() fails or not

or not what ?

This patch returns the setup error before accessing any registers.

s/This patch returns/Return/

(imperative mood, see Documentation/process/submitting-patches.rst)

Thanks,
Guenter

AI was used for peer-review the patch.

Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")

Signed-off-by: Vítor Hugo Silva <vitorhg20080@xxxxxxxxx>
---
drivers/hwmon/ads7871.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index 36297bc6d047..a1ffc35d9272 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
/* Configure the SPI bus */
spi->mode = (SPI_MODE_0);
spi->bits_per_word = 8;
- spi_setup(spi);
+ ret = spi_setup(spi);
+ if (ret)
+ return ret;
pdata = devm_kzalloc_obj(dev, *pdata);
if (!pdata)