Re: [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac

From: Florian Fainelli

Date: Tue Nov 17 2026 - 18:17:35 EST


On 11/16/26 13:34, Florian Fainelli wrote:
This patch series adds support for Clause 45 MDIO operations within the
mdio-bcm-unimac driver. The series breaks things up in this way:

- make the C45 bus scan done by the MDIO core carry on when nothing
answers at an address, as the C22 scan already does
- scope the existing defines to make it clear what is C22 vs. C45
specific
- rework the polling completion loop to be a tighter loop
- add support for clause 45 operations

Changes in v2:

- add patch 1, since providing read_c45/write_c45 makes the MDIO core scan
for C45 PHYs on all addresses that are not masked. On a bus registered
without a device tree node (e.g.: GENET with ACPI) a read from an empty
address fails with -EIO, which get_phy_c45_ids() passed up instead of
mapping it to -ENODEV, and made the whole bus registration fail. Reported
by Nicolai Buchwitz.
- patches 2 and 3: collect Reviewed-by tags from Andrew Lunn and Nicolai
Buchwitz, no code changes
- patch 4: no code changes

Florian Fainelli (4):
net: phy: Map C45 probe read errors to -ENODEV during bus scan
net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT
net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity
net: mdio: mdio-bcm-unimac: Add Clause 45 support

drivers/net/mdio/mdio-bcm-unimac.c | 130 +++++++++++++++++++++++++----
drivers/net/phy/phy_device.c | 24 ++++--
2 files changed, 134 insertions(+), 20 deletions(-)


Sashiko pointed some valid issues commenting on v1, and has not reviewed v2 yet which does not incorporate all of the feedback. There will be a v3 submitted that incorporates the received feedback.

pw-bot: cr
--
Florian