RE: [PATCH rtw-next v3 2/2] wifi: rtw88: 8822c: ignore nrx values without CCK PD registers

From: Ping-Ke Shih

Date: Tue Nov 17 2026 - 19:26:11 EST


Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> On November 17, 2026 7:38:21 AM GMT+01:00, Ping-Ke Shih
> <pkshih@xxxxxxxxxxx> wrote:
>
> [ ... ]
>
> > Since this only can happen when a device is removed suddenly, how about
> > reverting patch 1, and also validate bw <= RTW_CHANNEL_WIDTH_40 here.
>
> As far as I can see, rtw_set_channel() stores the bandwidth in hal and
> passes the same value to the chip's set_channel callback. We already
> use hal.current_band_width when setting TX power.
>
> CCK PD already checks hal.current_band_type and only runs on 2.4 GHz,
> where the bandwidth is 20 or 40 MHz. So I think using the stored value
> here is reasonable too. It avoids another register read and keeps a
> failed read from becoming the bandwidth index.
>
> Would you be okay with keeping patch 1 and using nrx > RF_PATH_B in
> patch 2, as you suggested?

From review point of view, validation the read value from registers
is easier.

To review patch 1, reviewers should trace the code to understand how
REG_TXBWCTL is. In driver side, yes, it is only modified by
rtw_set_channel(), but can you ensure firmware doesn't change it
(it should not)?

I'd prefer squashing two patches into one, and just validate the
read values. Commit message can be also simpler.