[PATCH v3] media: intel/ipu6: omit sequence number from EOF debug log
From: Valerii Sokolov
Date: Tue Nov 17 2026 - 19:45:19 EST
When handling IPU6_FW_ISYS_RESP_TYPE_FRAME_SOF in ipu6_isys_isr_one(),
stream->seq[stream->seq_index] is populated with the current sequence
and stream->seq_index is immediately advanced to the next ring buffer
slot.
Subsequently, when IPU6_FW_ISYS_RESP_TYPE_FRAME_EOF arrives, logging
stream->seq[stream->seq_index].sequence reads the next slot in the ring
buffer rather than the slot corresponding to the frame, printing a
stale or zero sequence number. Since the IPU firmware tracks frames by
timestamp rather than sequence number at EOF, omit the unreliable
sequence number from the EOF debug message.
Fixes: f50c4ca0a820 ("media: intel/ipu6: add the main input system driver")
Signed-off-by: Valerii Sokolov <valerii.sokolov@xxxxx>
---
Changes in v3:
- Omit printing the unreliable sequence number in the EOF debug message
instead of reading atomic_read(&stream->sequence) - 1 (Sakari Ailus).
- Dropped Antti's Reviewed-by tag due to the change in approach.
Changes in v2:
- Collected Reviewed-by from Antti Laakso.
drivers/media/pci/intel/ipu6/ipu6-fw-isys.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/pci/intel/ipu6/ipu6-fw-isys.c b/drivers/media/pci/intel/ipu6/ipu6-fw-isys.c
index 5d95fb9234..bfe91232d0 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-fw-isys.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-fw-isys.c
@@ -649,9 +649,8 @@ int ipu6_isys_isr_one(struct ipu6_bus_device *adev)
case IPU6_FW_ISYS_RESP_TYPE_FRAME_EOF:
ipu6_isys_csi2_eof_event_by_stream(stream);
dev_dbg(&adev->auxdev.dev,
- "eof: handle %d: (index %u), timestamp 0x%16.16llx\n",
- resp->stream_handle,
- stream->seq[stream->seq_index].sequence, ts);
+ "eof: handle %d: timestamp 0x%16.16llx\n",
+ resp->stream_handle, ts);
break;
case IPU6_FW_ISYS_RESP_TYPE_STATS_DATA_READY:
break;
--
2.56.0