Re: [PATCH net] l2tp: reject short IPv6 address attributes
From: Hangbin Liu
Date: Tue Nov 17 2026 - 20:51:22 EST
On Tue, Nov 17, 2026 at 06:21:57PM +0900, Hyunjung Ko wrote:
> L2TP_ATTR_IP6_SADDR and L2TP_ATTR_IP6_DADDR are NLA_BINARY with .len set
> to sizeof(struct in6_addr), which only bounds the attribute from above.
> l2tp_tunnel_sock_create() then copies a full in6_addr out of each one,
> so a shorter attribute makes it read past the payload. If the attribute
> is the last one in the message this picks up whatever lies behind the
> skb tail (stale heap data unless init_on_alloc is set), which ends up
> in the socket address and can be read back with L2TP_CMD_TUNNEL_GET.
>
> The commands are GENL_UNS_ADMIN_PERM, so this is reachable from a user
> namespace.
>
> Require the exact length.
>
> Fixes: f9bac8df908d ("l2tp: netlink api for l2tpv3 ipv6 unmanaged tunnels")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Hyunjung Ko <hj351016@xxxxxxxxx>
> ---
> net/l2tp/l2tp_netlink.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c
> index 89ef04c78787..a07009d4cb00 100644
> --- a/net/l2tp/l2tp_netlink.c
> +++ b/net/l2tp/l2tp_netlink.c
> @@ -910,14 +910,8 @@ static const struct nla_policy l2tp_nl_policy[L2TP_ATTR_MAX + 1] = {
> [L2TP_ATTR_MTU] = { .type = NLA_U16, },
> [L2TP_ATTR_MRU] = { .type = NLA_U16, },
> [L2TP_ATTR_STATS] = { .type = NLA_NESTED, },
> - [L2TP_ATTR_IP6_SADDR] = {
> - .type = NLA_BINARY,
> - .len = sizeof(struct in6_addr),
> - },
> - [L2TP_ATTR_IP6_DADDR] = {
> - .type = NLA_BINARY,
> - .len = sizeof(struct in6_addr),
> - },
> + [L2TP_ATTR_IP6_SADDR] = NLA_POLICY_EXACT_LEN(sizeof(struct in6_addr)),
> + [L2TP_ATTR_IP6_DADDR] = NLA_POLICY_EXACT_LEN(sizeof(struct in6_addr)),
> [L2TP_ATTR_IFNAME] = {
> .type = NLA_NUL_STRING,
> .len = IFNAMSIZ - 1,
> --
> 2.43.0
>
Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>