Re: [PATCH v2] MIPS: SiByte: Fix missing function prototypes

From: Maciej W. Rozycki

Date: Tue Nov 17 2026 - 20:58:02 EST


On Fri, 13 Nov 2026, Florian Fainelli wrote:

> The SB1250 SWARM build reports missing prototypes for platform time
> initialization, SoC setup, IRQ and SMP helpers, and both RTC backends.

Thank you for doing this. I've meant to for a long time, but have been
distracted with higher priority stuff.

> static inline int __maybe_unused bcm1250_m3_war(void)
> {
> - if (IS_ENABLED(CONFIG_SB1_PASS_2_WORKAROUNDS))
> - return sb1250_m3_workaround_needed();
> +#ifdef CONFIG_SB1_PASS_2_WORKAROUNDS
> + return sb1250_m3_workaround_needed();
> +#else
> return 0;
> +#endif
> }

It seems a style regression, why is this change needed?

Maciej