Re: [PATCH v2 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat

From: SJ Park

Date: Tue Nov 17 2026 - 21:07:19 EST


On Tue, 17 Nov 2026 23:22:14 +0000 Mattathias Pinchover via B4 Relay <devnull+mattathias.pinchover.uber.com@xxxxxxxxxx> wrote:

> DAMOS stat sz_ops_filter_passed shows the total bytes that passed
> operations layer-handled DAMOS filters, accumulated from the beginning
> of the scheme's execution. Users who want the amount for only the
> latest apply interval, e.g., the size of a workload's anonymous memory
> that is cold as of now, have to keep the previous value in user space
> and compute the difference. To know how many apply intervals a
> difference covers, they have to rely on nr_snapshots. But nr_snapshots
> is increased once per target per apply interval, so the computation is
> complicated for contexts having multiple targets.
>
> This series introduces a new DAMOS stat, sz_ops_filter_passed_last. It
> shows the amount of sz_ops_filter_passed increase in the last apply
> interval of the scheme. It is updated at the end of each apply
> interval, and kept unchanged until the next apply interval is
> completed. Like the other DAMOS stats, it is exposed under the stats/
> directory of the scheme in the DAMON sysfs interface, and refreshed
> together with the other stats when refresh_ms expires or
> update_schemes_stats is written.
[...]
> Changes in v2:
> - Patch 2: join the attribute declaration onto one line
> - Patch 3: call damos_set_filters_default_reject() before adding the
> scheme
> - Patch 4: keep only the stats list bullet, dropping the explanation
> that the stat is not accumulated
> - Patch 5: wrap the stats line in the usage document
> - Link to v1: https://patch.msgid.link/20261116-damon-sz-ops-b4-v1-0-1cffe7227e6d@xxxxxxxx

Thank you for addressing all comments I added to v1. However, you didn't
directly reply to the comments on the v1 thread. That might confuse some
future readers. From the next time, please make sure the previous version
thread is complete by replying to all comments and waiting sufficient time to
let any other chime in if they have opinions.

All patches in this version look good to me.

This series is applied to damon/next [1] tree. I will repost it soon (~1 week)
as an mm.git merge request. So, no action from your side is needed for now.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]