RE: [External Mail] Re: [PATCH net-next v12 1/6] net: wwan: t9xx: Add PCIe core
From: Wu. JackBB (GSM)
Date: Tue Nov 17 2026 - 21:42:01 EST
Hi Loic,
Thanks for the review.
On Tue, Nov 17, 2026 at 11:28 PM Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx> wrote:
> > + if (acpi_disabled) {
> > + dev_dbg(mdev->dev, "Unsupported, acpi function isn't enable\n");
>
> Go straight to the point: "ACPI is disabled\n"
Will fix in v13, with that wording.
> > + handle = ACPI_HANDLE(mdev->dev);
> > + if (!handle) {
> > + dev_dbg(mdev->dev, "Unsupported, acpi handle isn't found\n");
> > + return -ENODEV;
> > + }
> > + if (!acpi_has_method(handle, "MRST._RST")) {
> > + dev_dbg(mdev->dev, "Unsupported, pldr method isn't supported\n");
>
> "ACPI handle not found"
Will fix in v13: "ACPI handle not found" for the missing handle, and
"MRST._RST method not found" for the missing method.
> > + strscpy(mdev->dev_str, pci_name(pdev), MTK_DEV_STR_LEN);
>
> Do we really need this buffer to exist solely for IRQ names, can't we
> simply use dev_name()?
Will fix in v13: dev_str goes away and every name is built from
dev_name(). pci_request_irq() gets the format directly, so the per-IRQ
name buffer goes away as well.
Thanks,
Jack