回覆: [PATCH v2 1/9] dt-bindings: i3c: Document generic bus timing properties

From: Billy Tsai

Date: Tue Nov 17 2026 - 22:27:00 EST


> > + i3c-pp-scl-high-period-ns:
> > + description: |
>
> Needn't |

i3c-scl-hz and i2c-scl-hz above already use `description: |` with the
same blank-line-separated two-paragraph shape. Keeping this one plain
would make it inconsistent with the rest of the file. Did you want all
of them changed, or is this one special for some reason?

> Add
>
> minimum:
> maximum:
>
> to restrict validate rang.

Added minimum: 24 to i3c-pp-scl-high-period-ns and
i3c-pp-scl-low-period-ns (tHIGH/tLOW, MIPI I3C Basic Specification
v1.1.1 Table 87), and minimum: 200 to i3c-od-scl-low-period-ns
(tLOW_OD, Table 86).

i3c-od-scl-high-period-ns, i3c-pp-sda-hold-ns and
i3c-sr-p-scl-low-period-ns don't have a clean fixed value to add: the
spec doesn't give any of them a single constant minimum. I'd rather
leave those three alone than make one up.

> +dependencies:
> + i3c-pp-scl-high-period-ns:
> + - i3c-pp-scl-low-period-ns
> + i3c-pp-scl-low-period-ns:
> + - i3c-pp-scl-high-period-ns
> + i3c-od-scl-high-period-ns:
> + - i3c-od-scl-low-period-ns
> + i3c-od-scl-low-period-ns:
> + - i3c-od-scl-high-period-ns
>
> why need these dependencies? Suppose it should be default value if not
> existing.

tHIGH and tLOW together make up the SCL period for that timing mode.
Specifying only one leaves the override incomplete, since neither
value alone describes the resulting period or duty cycle. The
dependency keeps a half-specified pair out of a validated devicetree
rather than let it describe nothing meaningful.

Thanks

Billy Tsai