Re: [PATCH v2 0/9] cpufreq: tegra194: add Tegra264 support

From: Zhongqiu Han

Date: Tue Nov 17 2026 - 22:55:47 EST


On 11/17/2026 11:49 PM, Sumit Gupta wrote:
This series adds cpufreq support for Tegra264, which joins the SoCs
already supported by the tegra194-cpufreq driver.

Tegra264 keeps the existing model, where BPMP provides the NDIV limits.
The driver derives the current frequency from the core clock and
reference counters.

The main differences are:
- Frequency read: through system registers, as on Tegra194, but from
the 64-bit architected AMU counters. The reference counter ticks at
the system counter rate (CNTFRQ).


Hi Sumit,

Thanks for the update. All my v1 comments are addressed.

For patches 1-7 and 9:

Reviewed-by: Zhongqiu Han <zhongqiu.han@xxxxxxxxxxxxxxxx>

I left one comment on patch 8: the two AMU counters (core and constant)
are read separately in a kworker with interrupts enabled, so an
interrupt or preemption between the reads can skew the computed
frequency. Please have a look.


--
Thx and BRs,
Zhongqiu Han