Re: [PATCH v2] thermal: qcom-spmi-adc-tm5-gen3: move hardirq actions into threaded handler
From: Jishnu Prakash
Date: Wed Nov 18 2026 - 01:25:31 EST
Hi Andy,
On 11/13/2026 8:44 PM, Andy Shevchenko wrote:
> On Fri, Nov 13, 2026 at 05:23:03PM +0530, Jishnu Prakash wrote:
>> adc_tm5_probe() registers the ADC_TM interrupt with both a primary
>> handler and thread function (adctm5_gen3_isr/adctm5_gen3_isr_thread)
>> with IRQF_ONESHOT. The primary handler calls adc5_gen3_read(), which
>> takes the SPMI regmap's lock (a regular, non-raw spinlock) from hardirq
>> context. With CONFIG_PROVE_LOCKING enabled, this leads to a warning
>> about an attempt to take a lock in an invalid wait context:
>>
>> swapper/0/0 is trying to lock:
>> ffff000b67201018
>> (qcom_spmi_pmic:259:(&spmi_regmap_config)->lock){....}-{3:3}, at:
>> regmap_lock_spinlock+0x20/0x40
>> other info that might help us debug this:
>> context-{2:2}
>>
>> Call trace:
>> regmap_lock_spinlock+0x20/0x40
>> regmap_raw_read+0x88/0x328
>> regmap_bulk_read+0x10c/0x340
>> adc5_gen3_read+0x38/0x50 [qcom_spmi_adc5_gen3]
>> adctm5_gen3_isr+0x90/0x130 [qcom_spmi_adc_tm5_gen3]
>>
>> There is no requirement for any of the work done in the primary handler
>> to run in hardirq context. Drop the primary handler and move all the
>> actions in it to the threaded handler, which removes the invalid wait
>> context warning.
>>
>> Note that both handlers used a local variable to hold the index of the
>> SDAM whose IRQ was triggered ('sdam_num' in the primary handler and
>> 'sdam_index' in the thread function). These are the same value under
>> different names and 'sdam_index' is kept now, since that is the name
>> used for it at other places in the file.
>
> But this is not the point. The point should be semantics of the variable
> and not frequency of use.
>
OK, I see, the right reason for keeping the name 'sdam_index' instead of
'sdam_num' is that the variable represents an index instead of a count
and not simply that 'sdam_index' is the name used for it elsewhere.
I'll update the commit message to mention this, but do correct me
if I understood your comment wrongly.
> ...
>
>> -static irqreturn_t adctm5_gen3_isr(int irq, void *dev_id)
>> +static irqreturn_t adctm5_gen3_isr_thread(int irq, void *dev_id)
>> {
>> struct adc_tm5_gen3_chip *adc_tm5 = dev_id;
>> - int ret, sdam_num;
>> + int sdam_index, ret;
>> u8 tm_status[2];
>> u8 status, val;
>
> I probably missed to point that at the same time we can split semantically
> different variables.
>
> struct adc_tm5_gen3_chip *adc_tm5 = dev_id;
> u8 tm_status[2];
> u8 status, val;
> int sdam_index;
> int ret;
OK, I can make this change too in the next patch version.
Thanks,
Jishnu
>