Re: [PATCH] crypto: hifn_795x - Free walk pages on session setup failure
From: Eric Biggers
Date: Wed Nov 18 2026 - 01:55:46 EST
On Wed, Nov 18, 2026 at 02:19:17PM +0800, Haoxiang Li wrote:
> hifn_setup_session() allocates temporary pages for misaligned destination
> buffers. If the scatterlist walk fails or the hardware queue has
> insufficient capacity, these pages are not released. Retrying a queued
> request reinitializes the walk cache, losing the previous page pointers.
> Add a separate cleanup path to release the pages for misaligned requests.
>
> Fixes: f7d0561ea1da ("[CRYPTO] hifn_795x: HIFN 795x driver")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> ---
> drivers/crypto/hifn_795x.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
We should just delete this driver. It is heavily broken, 32-bit only,
and no one seems to have used it since 2008.
- Eric