Re: [PATCH v5 1/3] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings
From: Komal Bajaj
Date: Wed Nov 18 2026 - 02:00:37 EST
On 11/16/2026 4:28 PM, Krzysztof Kozlowski wrote:
On Fri, Nov 13, 2026 at 08:02:20PM +0530, Komal Bajaj wrote:
qcom,pas-common.yaml limits iommus to a single entry for every PASI do not understand this sentence. Compatible cannot declare iommus, but
remoteproc, which is too restrictive for SoCs whose firmware uses
multiple IOMMU streams.
Drop iommus from common binding and let each SoC-specific binding declare
it with its own limits. These bindings set unevaluatedProperties: false,
so a compatible that does not declare iommus rejects it. Declare it for
anyway the bindings do not reject it.
Right. Wording was incorrect, compatible does not declare property but schema does. I will reword this in next revision.
What I meant was that these bindings set unevaluatedProperties: false. Therefore, once iommus is removed from qcom,pas-common.yaml, any schema that does not define iommus itself will reject a node containing it with -
"Unevaluated properties are not allowed ('iommus' was unexpected)"
every compatible whose nodes use it.Same comments as before - missing property definition. Properties should
Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
---
.../devicetree/bindings/remoteproc/qcom,pas-common.yaml | 3 ---
.../devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml | 4 ++++
.../devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 12 ++++++++++++
.../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml | 13 +++++++++++++
.../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 15 +++++++++++++++
5 files changed, 44 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
index f75cab6b4ed9..4662fe4cff62 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
@@ -32,9 +32,6 @@ properties:
minItems: 5
maxItems: 6
- iommus:
- maxItems: 1
-
power-domains:
minItems: 1
maxItems: 3
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
index dda2d144b720..3c35da52204d 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
@@ -38,6 +38,10 @@ properties:
reg:
maxItems: 1
+ iommus:
+ maxItems: 1
+ description: Firmware Stream
+
clocks:
items:
- description: XO clock
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
index b20780e5e26b..8aebc785f212 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
@@ -169,6 +169,18 @@ allOf:
- const: cx
- const: mx
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7280-adsp-pas
+ - qcom,sc7280-cdsp-pas
+ then:
+ properties:
+ iommus:
+ maxItems: 1
not be defined in conditional blocks. If you remove property from common
schema, then you remove it from every device referencing it. Nothing in
commit msg explains such intention and reason why.
I will update this and keep it as a no-functional-change.
Either iommus is valid or is not. If it is not, then need mentioning in
commit msg for example and then you drop it from common schema and add
it to the bindings where it is valid.
I will cover this in a separate commit.
Thanks
Komal
Best regards,
Krzysztof