Re: [PATCH net-next v3 5/5] selftests: seg6: add PSP flavor testing for SRv6 End.X
From: Hangbin Liu
Date: Wed Nov 18 2026 - 02:07:04 EST
Hi Andrea,
On Wed, Nov 18, 2026 at 03:50:10AM +0100, Andrea Mayer wrote:
> > >
> > > Without NEXT-C-SID, get_rt_sid() drops the adjacency, as the Sashiko
> > > review also notes: "4>2:psp:End.X" and "4>3:psp:End.X" would both get
> > > fcff:4::0af1. I think each adjacency should have its own SID. The
> > > SID could carry the adjacency, as the C-SID already does. Then
> > > __setup_rt_policy() needs the new SID. Calling get_rt_sid() there,
> > > as suggested above, would do that.
> >
> > Hmm, do you want to set the adjacency like xaf1 or xxa1?
> > e.g. ffcf:4::2af1 for 4>2:psp:End.X, ffcf:4::3af1 for 4>3:psp:End.X
> > or
> > ffcf:4::42a1 for 4>2:psp:End.X, ffcf:4::43a1 for 4>3:psp:End.X?
> >
> > The second one may also need to adjust the End address. e.g.
> > fcff:x::ef1 -> fcff:x::e1
>
> The first one you propose, fcff:4::2af1, seems reasonable. The adjacency
> takes the place of the leading 0 of the Function (0af1 -> 2af1). Towards
> the host the 0 stays, as in the C-SID, and the End SIDs do not change.
What about noflv? e.g. 3>4:noflv:End.X, should we use addr like
fcff:3::4a?
Thanks
Hangbin