Re: [PATCH v10 19/28] KVM: x86: Advertise support for FRED
From: Sohil Mehta
Date: Wed Nov 18 2026 - 03:30:12 EST
On 11/1/2026 11:32 PM, Binbin Wu wrote:
> On 9/12/2026 5:36 AM, Sohil Mehta wrote:
>> From: "Xin Li (Intel)" <xin@xxxxxxxxx>
>>
>> Advertise support for FRED to userspace after changes required to enable
>> FRED in a KVM guest are in place.
>>
>> Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>
>> Signed-off-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>
>> Reviewed-by: Chao Gao <chao.gao@xxxxxxxxx>
>
> The code change itself looks good to me.
> But this patch should be moved after patch 25.
>
> X86_CR4_FRED is added to nested.msrs.cr4_fixed1 in patch 25, before that
> if the L1 guest enables FRED, it will break the nested case when do VMXON,
> which checks nested_host_cr4_valid() and it will fail during the bisect
> window before patch 25.
>
Good catch. Instead of moving this patch after the nested VMX support, I
am wondering if we could reorganize the patches slightly differently so
that the nested support can be split up from the L1 guest support.
The series is getting a bit bulky. I am trying to split this series into
smaller parts to make it easier to review. Planning to reply to Chang
email soon where he also suggested this.