Re: [PATCH] staging: greybus: audio_manager_module: add terminating newlines to sysfs output
From: Dan Carpenter
Date: Wed Nov 18 2026 - 03:55:30 EST
On Tue, Nov 17, 2026 at 10:55:15PM +0545, Chhabilal Dangal wrote:
> The sysfs show callbacks for name, vid, pid, intf_id, ip_devices and
> op_devices print their value without a trailing newline, so a read
> from userspace runs into the next line. Other sysfs attributes end
> with a newline.
>
> Add the missing newlines. No functional change beyond the output
> format.
The output format is a functional change and since it's somethng that
user space sees it's an ABI change. Just ignore the tools which give
wrong advice. checkpatch is just a perl script.
regards,
dan carpenter