Re: [PATCH v3 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5)
From: Joshua Crofts
Date: Wed Nov 18 2026 - 04:01:10 EST
On Tue, 17 Nov 2026 20:33:31 +0300
Adil Hüsrev Tepe <tadilhusrev@xxxxxxxxx> wrote:
> This series adds an IIO driver and its DT binding for the Imagis
> ISG5320A capacitive SAR/grip proximity sensor (I2C), as fitted on the
> Samsung Galaxy XCover5 (SM-G525F, Exynos850).
>
> Patch 1 dt-bindings
> Patch 2 the IIO driver
>
> v3 fixes the real review findings on v2: Sashiko AI caught a High-
> severity INT-polarity bug in the reset sequence (eliminated by
> dropping int-gpios from the driver and binding entirely, since the
> pin is already described by the required "interrupts" property) plus
> a Medium-severity devm unwind-order bug and a Low-severity unchecked
> enable_irq_wake(). Both are now live-tested, not just built. Per-patch
> details are below each patch's "---" line, as Andy Shevchenko asked.
>
> Tested on a Samsung Galaxy XCover5 running 7.4-rc1 plus this series
> (2026-11-17, kernel 7.4.0-rc1-00023-gdcb8b91fb779+ #30): the driver
> binds, registers as iio:device4 "isg5320a", and in_proximity0_raw
> tracked a live hand-proximity test (baseline ~0, swinging to
> -12817/9748/10759 as a hand approached/withdrew the sensor).
> checkpatch.pl --strict and dt_binding_check are clean.
>
> Based on v7.4-rc1.
>
> Tool usage
> ----------
> This series was developed during XCover5 mainline bring-up with the
> help of an AI coding assistant (Claude Code, Anthropic), which drafted
> the IIO driver from the Samsung vendor driver's register map and
> drafted these changelogs. I reviewed every line, built it (arm64, 0
> warnings), ran checkpatch --strict (clean), and tested it on hardware
> as described above, and take full responsibility for the contribution.
> Review comments are welcome and I will answer them myself.
>
> Adil Hüsrev Tepe (2):
> dt-bindings: iio: proximity: add Imagis ISG5320A
> iio: proximity: add Imagis ISG5320A SAR sensor driver
>
> .../bindings/iio/proximity/imagis,isg5320a.yaml | 55 ++
> drivers/iio/proximity/Kconfig | 11 +
> drivers/iio/proximity/Makefile | 1 +
> drivers/iio/proximity/isg5320a.c | 848 +++++++++++++++++++
> 4 files changed, 915 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml
> create mode 100644 drivers/iio/proximity/isg5320a.c
>
> --
> 2.53.0
>
Not only you sent this as a reply to v1 (which obscured this new version
in my inbox), you also sent a v3 the same day you sent a v2. This is a (relatively)
big addition, please don't do this. For trivial patches it should be at least 24 hours
between revisions, for new drivers ~1 week.
I know it's tempting to send a new version after a Sashiko review/trivial issue you
found, but you'll save the reviewers' and maintainer's sanity by waiting :)
Thanks!
--
Kind regards,
Joshua Crofts