Re: [PATCH 0/3] Fix three Clang context analysis issues
From: Marco Elver
Date: Wed Nov 18 2026 - 04:48:56 EST
On Tue, 17 Nov 2026 at 00:00, Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> Hi Peter and Marco,
>
> This patch series includes three context analysis fixes:
> - bit_spinlock: Surround the bitnum argument and macro expansion in
> __bitlock() with parentheses to avoid operator precedence issues.
> - cleanup: Mark __free() helper functions generated by DEFINE_FREE() as
> __context_unsafe() because cleanup expressions that unlock trigger
> Clang thread-safety false positives.
> - srcu: Move __srcu_read_lock_must_hold() out of
> srcu_dereference_check() and into srcu_dereference() and
> srcu_dereference_notrace() so update-side callers satisfying the
> lockdep condition do not fail context analysis.
>
> Please consider this patch series for the next merge window.
Acked-by: Marco Elver <elver@xxxxxxxxxx>
... modulo pending v2 that addresses the srcu patch's concerns from Paul.
> Thanks,
>
> Bart.
>
> Changes compared to v2:
> - Split out only the three standalone context analysis fixes (v2 patches
> 1, 2, and 4) into this series.
> - Dropped the lockdep and RCU assertion behavior changes (v2 patches
> 8-14: lockdep_assume_*(), lockdep_assume_in_rcu_*(), and removing
> context assumptions from lockdep_assert_held*() and
> lockdep_assert_in_rcu_*()), as agreed in the review discussion [2].
> - Dropped the preparatory __must_hold*() annotation patches (v2 patches
> 5-7) and the tracing branch profiling Kconfig patch (v2 patch 3) from
> this series.
> - Updated the commit message of "cleanup: Disable context analysis for
> __free() helpers" with concrete examples of __free() unlock helpers
> in response to review feedback.
> - Rebased onto current mainline.
>
> Bart Van Assche (3):
> bit_spinlock: Fix the __bitlock() definition
> cleanup: Disable context analysis for __free() helpers
> srcu: Remove check from srcu_dereference_check()
>
> include/linux/bit_spinlock.h | 2 +-
> include/linux/cleanup.h | 6 ++++--
> include/linux/srcu.h | 20 +++++++++++++++-----
> 3 files changed, 20 insertions(+), 8 deletions(-)
>