Re: [PATCH] rust: cfi: disable function merging if CFI is enabled
From: Alice Ryhl
Date: Wed Nov 18 2026 - 04:58:04 EST
On Tue, Nov 17, 2026 at 11:03 PM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> On Tue, Nov 17, 2026 at 12:58 PM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> >
> > Function merging should also be disabled with gendwarfksyms. It causes
> > faux::Registration::as_raw() and Page::as_ptr() to get merged, which
> > incorrectly causes the former to get the CRC of the latter.
>
> Sounds reasonable to me. Although, I assume this is only really a
> problem if the functions stop being merged later on, e.g. because
> they're no longer ABI compatible?
They take pointers to different things, so the one that got merged
definitely got the wrong CRC. They do not have the same signature.
Alice