Re: [PATCH 3/7] clk: meson: pll: Support active-low resets

From: Jerome Brunet

Date: Wed Nov 18 2026 - 05:01:27 EST


> The common PLL code assumes that the reset of a PLL is active high. The
> S7 HDMI PLL has an active-low reset, and its lock flag only rises
> reliably when the PLL goes through it.
>
> Add a flag for PLLs with an active-low reset so this PLL can use the
> common implementation.
>
> Signed-off-by: Carlo Caione <ccaione@xxxxxxxxxxxx>
> ---
> drivers/clk/meson/clk-pll.c | 43 +++++++++++++++++++++++++++++++------------
> drivers/clk/meson/clk-pll.h | 1 +
> 2 files changed, 32 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
> index 44b33051405f..4ac5e45c1e9b 100644
> --- a/drivers/clk/meson/clk-pll.c
> +++ b/drivers/clk/meson/clk-pll.c
> @@ -293,13 +293,37 @@ static int meson_clk_pll_wait_lock(struct clk_hw *hw)
> return -ETIMEDOUT;
> }
>
> +static bool meson_clk_pll_in_reset(struct clk_regmap *clk,
> + struct meson_clk_pll_data *pll)
> +{
> + unsigned int rst;
> +
> + if (!MESON_PARM_APPLICABLE(&pll->rst))
> + return false;
> +
> + rst = meson_parm_read(clk->map, &pll->rst);
> +
> + return pll->flags & CLK_MESON_PLL_RST_ACTIVE_LOW ? !rst : rst;

nitpick: exclusive or ?

> +}
> +
> +static void meson_clk_pll_reset(struct clk_regmap *clk,
> + struct meson_clk_pll_data *pll, bool reset)
> +{
> + if (!MESON_PARM_APPLICABLE(&pll->rst))
> + return;
> +
> + if (pll->flags & CLK_MESON_PLL_RST_ACTIVE_LOW)
> + reset = !reset;

same here.

Apart from that

Reviewed-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

--
Jerome