Re: [PATCH v2 3/4] iio: light: stk3310: add vdd regulator support

From: Joshua Crofts

Date: Wed Nov 18 2026 - 05:02:12 EST


On Tue, 17 Nov 2026 20:08:37 +0200
Roman Vivchar via B4 Relay <devnull+rva333.protonmail.com@xxxxxxxxxx> wrote:

> @@ -745,6 +746,10 @@ static int stk3310_probe(struct i2c_client *client)
> device_property_read_u32(&client->dev, "proximity-near-level",
> &data->ps_near_level);
>
> + ret = devm_regulator_get_enable(dev, "vdd");
> + if (ret)
> + return dev_err_probe(dev, ret, "failed to get vdd supply\n");
> +

IMO this should work, but I don't like the mixing of devm_* and non-devm_*
functions, this may cause issues down the road. Consider moving the driver
to all devm_* functions?

--
Kind regards,
Joshua Crofts