Re: [PATCH 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc()
From: Heiko Carstens
Date: Wed Nov 18 2026 - 05:09:26 EST
On Wed, Nov 18, 2026 at 09:11:26AM +0000, David Laight wrote:
> On Mon, 16 Nov 2026 16:22:16 +0100
> Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
> > It is a bit subtle that this really works. EXT_SCCB_READ_CPU is 3 * PAGE_SIZE,
> > so we end up with a guaranteed 4k alignment from the slab cache, which is
> > indeed sufficient here. But this is really not obvious, and not as stable as
> > before, IMHO.
> >
> > I'd prefer to have this changed to:
> >
> > sccb = kzalloc(PAGE_SIZE << get_order(length), GFP_KERNEL | GFP_DMA);
> >
> > which comes with the same alignment guarantees as before.
>
> Would it be better (more obvious) to round up EXT_SCCB_READ_CPU ?
Mike sent already a new version; this is now good enough.