Re: [PATCH v2] iio: light: bh1745: fix 16-bit register accesses

From: Matti Vaittinen

Date: Wed Nov 18 2026 - 05:32:39 EST


On 17/11/2026 16:21, Andy Shevchenko wrote:
+ Cc: Matti (even he is not listed as maintainer) for possible another pair of
eyes and/or having an answer why this was missed at the time of the driver
submission (from my perspective this patch is correct).

Thanks for the heads-up Andy. Unfortunately, I have never worked with this IC, and I don't think we have it in the ROHM Finland office (but I'll check this just in case. It'd be nice to have this covered in my test setup).

What comes to missing this in reviews... Well, I suppose the reviewers are just humans, or if they're not, then they might have concentrated on other important things, like styling, instead of the real functionality.

On my own behalf, I was away for 1.5 months when the series was applied, and I only looked at the GTS-helpers usage when I did my shallow and badly belated review. (Furthermore, I am 100% human, so I might have just missed this even if I had all the time in the world to do the review).

Yours,
-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~