Re: [PATCH v2 5/6] reset: starfive: jh71x0: Support discontiguous reset IDs
From: Philipp Zabel
Date: Wed Nov 18 2026 - 05:40:41 EST
On Mi, 2026-11-18 at 02:05 -0800, Changhuang Liang wrote:
> The reset IDs exposed to consumers of the StarFive JHB100 reset
> controllers do not map one-to-one to the hardware reset bits.
>
> Add struct jh71x0_reset_info, which describes the number of resets, the
> assert/status register offsets and, for such controllers, a table of
> hardware reset lines indexed by reset ID. Add
> reset_starfive_jh71x0_register_with_info() to register a controller
> described this way.
>
> If a map is provided, install a custom fwnode_xlate callback that
> translates the reset ID of the reset specifier to the hardware reset
> line. The translation is thus done once when a reset control is
> requested, and the reset operations are left untouched since they only
> ever see hardware reset lines.
>
> Existing users of reset_starfive_jh71x0_register() are unaffected.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> ---
> .../reset/starfive/reset-starfive-jh71x0.c | 60 +++++++++++++++++++
> .../reset/starfive/reset-starfive-jh71x0.h | 24 ++++++++
> 2 files changed, 84 insertions(+)
>
> diff --git a/drivers/reset/starfive/reset-starfive-jh71x0.c b/drivers/reset/starfive/reset-starfive-jh71x0.c
> index d410a5a0ded4..5c64d47fb530 100644
> --- a/drivers/reset/starfive/reset-starfive-jh71x0.c
> +++ b/drivers/reset/starfive/reset-starfive-jh71x0.c
[...]
> @@ -132,3 +152,43 @@ int reset_starfive_jh71x0_register(struct device *dev, struct device_node *of_no
> return devm_reset_controller_register(dev, &data->rcdev);
> }
> EXPORT_SYMBOL_GPL(reset_starfive_jh71x0_register);
> +
> +int reset_starfive_jh71x0_register_with_info(struct device *dev, struct device_node *of_node,
> + void __iomem *assert, void __iomem *status,
> + const u32 *asserted,
> + const struct jh71x0_reset_info *info,
> + struct module *owner)
> +{
> + struct jh71x0_reset *data;
> + int ret;
> +
> + data = devm_kzalloc_obj(dev, *data);
> + if (!data)
> + return -ENOMEM;
> +
> + data->rcdev.ops = &jh71x0_reset_ops;
> + data->rcdev.owner = owner;
> + data->rcdev.nr_resets = info->nr_resets;
> + data->rcdev.dev = dev;
> + data->rcdev.of_node = of_node;
> +
> + if (info->map) {
> + data->map = info->map;
> + data->rcdev.fwnode_xlate = jh71x0_reset_fwnode_xlate;
> + data->rcdev.fwnode_reset_n_cells = 1;
> + }
> +
> + spin_lock_init(&data->lock);
> + data->assert = assert;
> + data->status = status;
> + data->asserted = asserted;
> +
> + ret = devm_reset_controller_register(dev, &data->rcdev);
> + if (ret < 0)
> + return dev_err_probe(dev, ret, "Failed to register reset controller\n");
> +
> + dev_info(dev, "Registered %u resets\n", data->rcdev.nr_resets);
Does this really need to be this verbose? Otherwise,
Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
regards
Philipp