[PATCH v2 3/3] power: reset: Remove SpacemiT P1 reboot driver

From: Anand Moon

Date: Wed Nov 18 2026 - 05:50:15 EST


The SpacemiT P1 reboot driver uses I2C-backed regmap operations to
request system shutdown and restart through the PMIC.

The system-off handlers run in atomic context, where regmap operations
may sleep. This can trigger invalid wait context and
scheduling-while-atomic warnings during shutdown or restart.

On SpacemiT K1 platforms, system poweroff and restart are handled by
OpenSBI through the SBI System Reset (SRST) extension. The Linux PMIC
reboot driver duplicates this firmware functionality and is no longer
needed.

Remove the driver along with its Kconfig and Makefile entries.
The P1 MFD driver and its other functionality remain unaffected.

Cc: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
Cc: Aurelien Jarno <aurelien@xxxxxxxxxxx>
Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
---
New patch
---
drivers/power/reset/Kconfig | 9 ---
drivers/power/reset/Makefile | 1 -
drivers/power/reset/spacemit-p1-reboot.c | 87 ------------------------
3 files changed, 97 deletions(-)
delete mode 100644 drivers/power/reset/spacemit-p1-reboot.c

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index bce996bbef28..9e997d58fcc6 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -295,15 +295,6 @@ config POWER_RESET_KEYSTONE
help
Reboot support for the KEYSTONE SoCs.

-config POWER_RESET_SPACEMIT_P1
- tristate "SpacemiT P1 poweroff and reset driver"
- depends on ARCH_SPACEMIT || COMPILE_TEST
- depends on MFD_SPACEMIT_P1
- default MFD_SPACEMIT_P1
- help
- This driver supports power-off and reset operations for the SpacemiT
- P1 PMIC.
-
config POWER_RESET_SYSCON
bool "Generic SYSCON regmap reset driver"
depends on OF
diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
index e31cab4ba78e..2d5bdd1584cc 100644
--- a/drivers/power/reset/Makefile
+++ b/drivers/power/reset/Makefile
@@ -25,7 +25,6 @@ obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o
obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o
obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o
obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o
-obj-$(CONFIG_POWER_RESET_SPACEMIT_P1) += spacemit-p1-reboot.o
obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o
obj-$(CONFIG_POWER_RESET_TH1520_AON) += th1520-aon-reboot.o
obj-$(CONFIG_POWER_RESET_TORADEX_EC) += tdx-ec-poweroff.o
diff --git a/drivers/power/reset/spacemit-p1-reboot.c b/drivers/power/reset/spacemit-p1-reboot.c
deleted file mode 100644
index c0454b547718..000000000000
--- a/drivers/power/reset/spacemit-p1-reboot.c
+++ /dev/null
@@ -1,87 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Copyright (C) 2025 by Aurelien Jarno
- */
-
-#include <linux/bits.h>
-#include <linux/platform_device.h>
-#include <linux/regmap.h>
-#include <linux/reboot.h>
-
-/* Power Control Register 2 */
-#define PWR_CTRL2 0x7e
-#define PWR_CTRL2_SHUTDOWN BIT(2) /* Shutdown request */
-#define PWR_CTRL2_RST BIT(1) /* Reset request */
-
-static int spacemit_p1_pwroff_handler(struct sys_off_data *data)
-{
- struct regmap *regmap = data->cb_data;
- int ret;
-
- /* Put the PMIC into shutdown state */
- ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_SHUTDOWN);
- if (ret) {
- dev_err(data->dev, "shutdown failed: %d\n", ret);
- return notifier_from_errno(ret);
- }
-
- return NOTIFY_DONE;
-}
-
-static int spacemit_p1_restart_handler(struct sys_off_data *data)
-{
- struct regmap *regmap = data->cb_data;
- int ret;
-
- /* Put the PMIC into reset state */
- ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_RST);
- if (ret) {
- dev_err(data->dev, "restart failed: %d\n", ret);
- return notifier_from_errno(ret);
- }
-
- return NOTIFY_DONE;
-}
-
-static int spacemit_p1_reboot_probe(struct platform_device *pdev)
-{
- struct device *dev = &pdev->dev;
- struct regmap *regmap;
- int ret;
-
- regmap = dev_get_regmap(dev->parent, NULL);
- if (!regmap)
- return -ENODEV;
-
- ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler,
- regmap);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to register power off handler\n");
-
- ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler,
- regmap);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to register restart handler\n");
-
- return 0;
-}
-
-static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
- { .name = "spacemit-p1-reboot" },
- { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
-
-static struct platform_driver spacemit_p1_reboot_driver = {
- .driver = {
- .name = "spacemit-p1-reboot",
- },
- .probe = spacemit_p1_reboot_probe,
- .id_table = spacemit_p1_reboot_id_table,
-};
-module_platform_driver(spacemit_p1_reboot_driver);
-
-MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
-MODULE_LICENSE("GPL");
--
2.56.0