Re: [PATCH net v5 0/3] mptcp token hash ordering and token 0 lookups
From: Matthieu Baerts
Date: Wed Nov 18 2026 - 05:50:47 EST
Hi Hang Nan,
On 16/11/2026 15:58, Hang Nan wrote:
> This series restores acquire ordering for the mptcp token lookup and fixes
> two pre-existing defects in that hash table which ordering alone cannot
> cover.
I didn't do a full review of this series because of the build failures,
but here are just a couple of quick notes:
- The patches you send are not linked to the cover-letter, see the
In-Reply-To [1] pointing to a different Message-ID than the
cover-letter [2]. Your messages ID are probably modified when sent.
- Please wait for Netdev Sashiko [3] before sending new versions.
- Use 'mptcp:' prefix instead of 'net: mptcp:'
- Split the new kunit tests from the modification in the code to ease
backports.
- (Honestly, a test for a !token guard is probably not worth 50 lines.
The first KUNIT_EXPECT_PTR_EQ on the empty table, or no new test at
all seems more reasonable.)
- (I agree that the Token 0 is never assigned... in Linux: the RFC8684
accepts it, but the Linux implementation don't. Maybe mention that in
the commit message to avoid confusions.)
[1] https://lore.kernel.org/tencent_BB8DA72524E32FD374B8B2950B247B62E207@xxxxxx
[2] https://lore.kernel.org/tencent_50E9A78F95855D54DA67136F3D8520017F0A@xxxxxx
[3] https://netdev-ai.bots.linux.dev/sashiko/
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.