Re: [PATCH v2 02/15] drivers/perf: apple_m1: Remove unused variables

From: Marc Zyngier

Date: Wed Nov 18 2026 - 06:13:53 EST


On Sat, 07 Nov 2026 10:48:49 +0000,
Myria Sarvay via B4 Relay <devnull+myrialsarvay.gmail.com@xxxxxxxxxx> wrote:
>
> From: Myria Sarvay <myrialsarvay@xxxxxxxxx>
>
> These variables are calculated elsewhere as well, remove the extra dead
> code.
>
> Signed-off-by: Myria Sarvay <myrialsarvay@xxxxxxxxx>
> Fixes: a639027a1be1 ("drivers/perf: Add Apple icestorm/firestorm CPU PMU driver")

Not quite. In this patch, the variables were very much in use. They
became useless with 75ecffc361bbc ("drivers/perf: apple_m1: Refactor
event select/filter configuration").

Please adjust the tag accordingly, or just drop it because this really
isn't a fix, only a minor cleanup.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.