RE: [PATCH] EDAC/igen6: Unregister the correct error handler on probe failure
From: Qiuxu (Leo) Zhuo
Date: Wed Nov 18 2026 - 06:33:19 EST
> From: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> Sent: Wednesday, November 18, 2026 4:42 PM
> To: tony.luck@xxxxxxxxx; Qiuxu (Leo) Zhuo <qzhuo@xxxxxxxxxx>; bp@xxxxxxxxx
> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Haoxiang Li
> <haoxiang_li2024@xxxxxxx>
> Subject: [PATCH] EDAC/igen6: Unregister the correct error handler on probe failure
>
>
> register_err_handler() registers either an NMI handler or an MCE notifier
> depending on res_cfg->machine_check. If enabling error reporting fails,
> igen6_probe() always unregisters the NMI handler, leaving the MCE notifier
> registered while the driver resources are released.
>
> Use unregister_err_handler() in the probe error path to match the registration
> method, as already done in igen6_remove().
>
> Fixes: 0b7338b27e82 ("EDAC/igen6: Add Intel Tiger Lake SoC support")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> ---
> drivers/edac/igen6_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c index
> 776c5db2f598..a2207337f251 100644
> --- a/drivers/edac/igen6_edac.c
> +++ b/drivers/edac/igen6_edac.c
> @@ -1948,7 +1948,7 @@ static int igen6_probe(struct pci_dev *pdev, const struct
> pci_device_id *ent)
> igen6_debug_setup();
> return 0;
> fail4:
> - unregister_nmi_handler(NMI_SERR, IGEN6_NMI_NAME);
> + unregister_err_handler();
Thanks for the patch.
Could you also drain ecclog_irq_work and ecclog_work before destroying the pool by gen_pool_destroy(),
as igen6_remove() already does:
+irq_work_sync(&ecclog_irq_work);
+flush_work(&ecclog_work);
> fail3:
> gen_pool_destroy(ecclog_pool);
> fail2:
> --
> 2.25.1