Re: [PATCH v2 2/2] arm64: dts: exynos: Add initial support for Samsung Galaxy Note8
From: Trần Trung Nhân
Date: Wed Nov 18 2026 - 06:38:13 EST
Hi Peter,
On Wed, 18 Nov 2026 at 10:51, Peter Griffin <peter.griffin@xxxxxxxxxx> wrote:
> Does the Samsung bootloader not pass a correctly populated memory node
> for the device? Or is this required because UniLoader doesn't pass
> along the memory node it received from the previous stage bootloader?
>From what I can check here, it's a bit of both. S-Boot doesn't build
the memory node itself. It loads the DTB from the boot image it boots
(BOOT, or RECOVERY as in my test); it checks that a /memory node
exists, and only fills in the bank at 0x900000000
(reg = <0x9 0x0 0x80000000>) when it detects 6GB of DRAM. The other
three banks have to be in the DTB already. Samsung's own device tree
for this phone lists them and leaves the size of the fourth bank as 0
for S-Boot to fill in. From
arch/arm64/boot/dts/exynos/exynos8895-greatlte_common.dtsi in
Samsung's kernel source release for the Note8 (SM-N950F_PP_Opensource,
N950FXXSGDUG6, on opensource.samsung.com):
memory@80000000 {
device_type = "memory";
reg = <0x0 0x80000000 0x3C800000>;
};
memory@C0000000 {
device_type = "memory";
reg = <0x0 0xC0000000 0x40000000>;
};
memory@880000000 {
device_type = "memory";
reg = <0x00000008 0x80000000 0x80000000>;
};
memory@900000000 {
device_type = "memory";
reg = <0x00000009 0x00000000 0x0>;
};
The DTB in the stock SM-N950N BOOT image (N950NKSU5DZE2) has the same
four nodes.
S-Boot does the same on SM-N950F: the device tree fixups in its
N950FXXSGDUG6 bootloader are the same code as in the SM-N950N
N950NKSU5DZE2 one. Every Exynos Note8 ships with 6GB of RAM, so the
fourth bank is always filled in and the DTS doesn't need to differ
between them.
uniLoader then doesn't pass that DTB on. It boots the kernel with the
DTB linked into it and only adds the initrd properties to /chosen, so
nothing S-Boot wrote reaches the kernel and the memory node has to be in
the DTS. dreamlte and starlte do the same for the same reason.
btw, the name's Nhân; Trần is the family name, and if the convention is
to write first name first, I'd be pleased to adjust!
Thanks,
Nhân