Re: [PATCH v3 10/17] mtd: spi-nor: Fix SWP for octal DTR chips

From: Michael Walle

Date: Wed Nov 18 2026 - 07:25:17 EST


On Tue Oct 13, 2026 at 6:34 PM CEST, Miquel Raynal wrote:
> During the recent rework of status registers handling, we mostly focused
> on quad capable devices, partially skipping ODTR devices in our mental
> model. It seems that many (if not all?) ODTR devices have no SR2 read
> opcode and have other control mechanisms. Because of that, the current
> support in swp.c is broken, because reading back the written value may
> or may not lead to the expected result.

Is this still the case with the recent fix for the .read_sr2 opcode
from Haibo Chen [1]?

-michael

[1] https://lore.kernel.org./r/20261023-spi-nor-fix-v5-1-bb6e0ce21169@xxxxxxx

> Let's extend the _careful() suffix to the helper reading back the values
> and comparing them. Maybe this "carfulness" will have to be moved back
> to the core, it is a bit early to state it. For now, let's just make
> sure that we read back 0s without errors when virtually accessing SR2 on
> those chips.

Attachment: signature.asc
Description: PGP signature