Re: [PATCH v17 08/12] accel/rocket: select the per-core clock and reset counts from match data

From: Daniel Drake

Date: Wed Nov 18 2026 - 07:28:05 EST


On 14/11/2026 03:05, Jiaxing Hu wrote:
> The RK3576 and the RK3588 use the same NPU block, but with different
> numbers of clocks and resets.
>
> Take the number of clocks and resets for each core from soc_data in the
> match data, so the driver uses the right count on each SoC.


Rather than these clock and reset count rules via soc_data here, can we
just rely on the DT validation that is almost equivalent?

Then we can use devm_clk_bulk_get_all() and
devm_reset_control_array_get_exclusive() and not worry about checking
counts and names within the driver.

dtbs_check will already catch cases where the wrong number of clocks or
resets is provided, or where the names don't match the ones expected in
the bindings.

> static int rocket_probe(struct platform_device *pdev)
> {
> + const struct rocket_soc_data *soc = of_device_get_match_data(&pdev->dev);
> int ret;
>
> + if (!soc) {
> + dev_err(&pdev->dev, "no match data for this device\n");
> + return -ENODEV;
> + }


Since this would only be caused by a programming error, no print is
necessary.