Re: [PATCH v17 10/12] accel/rocket: add a GET_PARAM ioctl for the hardware version
From: Daniel Drake
Date: Wed Nov 18 2026 - 07:28:42 EST
Hi,
On 14/11/2026 03:05, Jiaxing Hu wrote:
> Add DRM_IOCTL_ROCKET_GET_PARAM so that userspace can query the NPU
> hardware version and pick the matching hardware description, such as the
> SRAM configuration and the register layout.
>
> Add DRM_ROCKET_PARAM_HW_VERSION, which returns a hardware version enum
> that matches the device tree compatible.
>
> The enum starts at 1 and 0 is not used:
>
> RK3588: 1
> RK3576: 2
I wonder if REG_PC_VERSION / REG_PC_VERSION_NUM could be used instead of
creating our own numbering scheme?
> diff --git a/drivers/accel/rocket/rocket_core.h b/drivers/accel/rocket/rocket_core.h
> index ef7043046bc6..50c8b05bd394 100644
> --- a/drivers/accel/rocket/rocket_core.h
> +++ b/drivers/accel/rocket/rocket_core.h
> @@ -41,6 +41,7 @@ struct rocket_soc_data {
> unsigned int num_clks;
> unsigned int num_resets;
> bool task_con_16bit;
> + u32 hw_version;
> };
If we're adding hw_version here then perhaps the task_con register
selection could be made based on the hw_version field value. Then we
don't need an extra flag.
> +static int
> +rocket_ioctl_get_param(struct drm_device *dev, void *data, struct drm_file *file)
> +{
> + struct rocket_device *rdev = to_rocket_device(dev);
> + struct drm_rocket_get_param *args = data;
> + const struct rocket_soc_data *soc;
> +
> + if (args->reserved != 0) {
> + drm_dbg(dev, "Reserved field in drm_rocket_get_param struct should be 0.\n");
> + return -EINVAL;
> + }
> +
> + soc = READ_ONCE(rdev->cores[0].soc);
Does it make sense to do READ_ONCE if the variable was not written with
WRITE_ONCE?
If my quick read of commits like 89c2c777df17 is correct, it's possible
that there are gaps anywhere in the cores[] list; please double check if
it's safe to always assume core 0 exists.
> +/**
> + * enum drm_rocket_param - parameters for DRM_IOCTL_ROCKET_GET_PARAM
> + * @DRM_ROCKET_PARAM_HW_VERSION: an enum drm_rocket_hw_version value.
> + */
> +enum drm_rocket_param {
> + DRM_ROCKET_PARAM_HW_VERSION = 0,
> +};
> +
> +/**
> + * enum drm_rocket_hw_version - the NPU, one value per DT compatible
> + * @DRM_ROCKET_HW_RK3588: "rockchip,rk3588-rknn-core"
> + * @DRM_ROCKET_HW_RK3576: "rockchip,rk3576-rknn-core"
> + */
Let's not document these as a match against compatible and their values,
just state it as a way of identifying the NPU chipset.