[PATCH RFC v2 06/16] media: mc: Maintain a list of open file handles in a media device
From: Mattijs Korpershoek
Date: Wed Nov 18 2026 - 07:45:00 EST
From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
The list of file handles is needed to deliver media events in the future.
Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Signed-off-by: Mattijs Korpershoek <mkorpershoek@xxxxxxxxxx>
---
drivers/media/mc/mc-device.c | 35 +++++++++++++++++++++++++----------
include/media/media-device.h | 7 +++++++
include/media/media-fh.h | 32 ++++++++++++++++++++++++++++++++
3 files changed, 64 insertions(+), 10 deletions(-)
diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
index 8d0c35a11944..b64322efd99e 100644
--- a/drivers/media/mc/mc-device.c
+++ b/drivers/media/mc/mc-device.c
@@ -22,6 +22,7 @@
#include <media/media-device.h>
#include <media/media-devnode.h>
#include <media/media-entity.h>
+#include <media/media-fh.h>
#include <media/media-request.h>
#ifdef CONFIG_MEDIA_CONTROLLER
@@ -35,16 +36,6 @@
#define MEDIA_ENT_SUBTYPE_MASK 0x0000ffff
#define MEDIA_ENT_T_DEVNODE_UNKNOWN (MEDIA_ENT_F_OLD_BASE | \
MEDIA_ENT_SUBTYPE_MASK)
-
-struct media_device_fh {
- struct media_devnode_fh fh;
-};
-
-static inline struct media_device_fh *media_device_fh(struct file *filp)
-{
- return container_of(filp->private_data, struct media_device_fh, fh);
-}
-
/* -----------------------------------------------------------------------------
* Userspace API
*/
@@ -56,7 +47,10 @@ static inline void __user *media_get_uptr(__u64 arg)
static int media_device_open(struct file *filp)
{
+ struct media_devnode *devnode = filp->private_data;
+ struct media_device *mdev = devnode->media_dev;
struct media_device_fh *fh;
+ unsigned long flags;
fh = kzalloc_obj(*fh);
if (!fh)
@@ -64,12 +58,25 @@ static int media_device_open(struct file *filp)
filp->private_data = &fh->fh;
+ spin_lock_irqsave(&mdev->fh_list_lock, flags);
+ list_add(&fh->mdev_list, &mdev->fh_list);
+ spin_unlock_irqrestore(&mdev->fh_list_lock, flags);
+
return 0;
}
static int media_device_close(struct file *filp)
{
+ struct media_devnode *devnode = media_devnode_data(filp);
+ struct media_device *mdev = devnode->media_dev;
struct media_device_fh *fh = media_device_fh(filp);
+ unsigned long flags;
+
+ if (mdev) {
+ spin_lock_irqsave(&mdev->fh_list_lock, flags);
+ list_del(&fh->mdev_list);
+ spin_unlock_irqrestore(&mdev->fh_list_lock, flags);
+ }
kfree(fh);
@@ -732,12 +739,14 @@ void media_device_init(struct media_device *mdev)
INIT_LIST_HEAD(&mdev->pads);
INIT_LIST_HEAD(&mdev->links);
INIT_LIST_HEAD(&mdev->entity_notify);
+ INIT_LIST_HEAD(&mdev->fh_list);
mutex_init(&mdev->req_queue_mutex);
mutex_init(&mdev->graph_mutex);
ida_init(&mdev->entity_internal_idx);
atomic_set(&mdev->request_id, 0);
+ spin_lock_init(&mdev->fh_list_lock);
if (!*mdev->bus_info)
media_set_bus_info(mdev->bus_info, sizeof(mdev->bus_info),
@@ -843,6 +852,7 @@ void media_device_unregister(struct media_device *mdev)
struct media_entity *next;
struct media_interface *intf, *tmp_intf;
struct media_entity_notify *notify, *nextp;
+ unsigned long flags;
if (mdev == NULL)
return;
@@ -883,6 +893,11 @@ void media_device_unregister(struct media_device *mdev)
dev_dbg(mdev->dev, "Media device unregistered\n");
debugfs_remove_recursive(mdev->media_dir);
+
+ spin_lock_irqsave(&mdev->fh_list_lock, flags);
+ list_del_init(&mdev->fh_list);
+ spin_unlock_irqrestore(&mdev->fh_list_lock, flags);
+
device_remove_file(&mdev->devnode->dev, &dev_attr_model);
media_devnode_unregister(mdev->devnode);
/* devnode free is handled in media_devnode_*() */
diff --git a/include/media/media-device.h b/include/media/media-device.h
index 749c327e3c58..2e737fec1afc 100644
--- a/include/media/media-device.h
+++ b/include/media/media-device.h
@@ -112,6 +112,10 @@ struct media_device_ops {
* @media_dir: DebugFS media directory
* @request_id: Used to generate unique request IDs
*
+ * @fh_list: List of file handles in the media device
+ * (struct media_device_fh.mdev_list).
+ * @fh_list_lock: Serialise access to fh_list list.
+ *
* This structure represents an abstract high-level media device. It allows easy
* access to entities and provides basic media device-level support. The
* structure can be allocated directly or embedded in a larger structure.
@@ -189,6 +193,9 @@ struct media_device {
/* debugfs */
struct dentry *media_dir;
atomic_t request_id;
+
+ struct list_head fh_list;
+ spinlock_t fh_list_lock;
};
/* We don't need to include usb.h here */
diff --git a/include/media/media-fh.h b/include/media/media-fh.h
new file mode 100644
index 000000000000..14ae4daaaddd
--- /dev/null
+++ b/include/media/media-fh.h
@@ -0,0 +1,32 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Media device file handle
+ *
+ * Copyright (C) 2019 Intel Corporation
+ */
+
+#ifndef MEDIA_FH_H
+#define MEDIA_FH_H
+
+#include <linux/list.h>
+#include <linux/file.h>
+
+#include <media/media-devnode.h>
+
+/**
+ * struct media_device_fh - File handle specific information on MC
+ *
+ * @fh: The media device file handle
+ * @mdev_list: This file handle in media device's list of file handles
+ */
+struct media_device_fh {
+ struct media_devnode_fh fh;
+ struct list_head mdev_list;
+};
+
+static inline struct media_device_fh *media_device_fh(struct file *filp)
+{
+ return container_of(filp->private_data, struct media_device_fh, fh);
+}
+
+#endif /* MEDIA_FH_H */
--
2.56.0